Starting the Frontend Mentor journey with the easiest challenge

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @ibnsamy96 👋🏻

  • In your markup, <div class="">...</div> should be <main class="">...</main>. This will fix the accessibility issues, but don't forget to generate a new repot once you fix the issues.
  • Next, for the music icon, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here.
  • Also, I suggest adding transition: all 0.2s; to the button and the links, this will make :hover smoother.

  I hope this was helpful 👨🏻‍💻 Other than that, you did a pixel perfect job, well done. Cheers 👾

  Marked as helpful

  1

  ---

  

  Mahmoud Samy•20

  @ibnsamy96Posted about 3 years ago

  Thanks @kens-visuals for your feedback. I appreciate it and solved my accessibility issues with the help of it.

  0

  

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  @ibnsamy96 you're welcome 😇

  1