Design comparison
Solution retrospective
Hi guys! This was my first challenge, I think I might have gone a little crazy with nesting the divs, and I could not get my font as thin looking as the one in the example. Overall, I'm really pleased with the outcome! Learned quite a bit as I made my way through the problem - looking forward to hearing back from you guys!
Community feedback
- @pablowbkPosted almost 5 years ago
Congrats on submitting your solution!! Aside from the heading's font size, I think you can work on the cards' padding a little bit, so as to get your solution closer to the design. But that's just being picky =P, you've done great! keep 'em coming!
1 - @mattstuddertPosted almost 5 years ago
Nice work on this challenge Perry and congrats on submitting your first solution! Your HTML structure looks great. You could add a
main
element instead of adiv
for the main wrapping element, but you're definitely not overusing them 🙂I would recommend reviewing your heading hierarchy. At the moment you've got
h1
,h3
, andh4
headings. I would recommend not skipping heading levels as you've done withh2
here, as it can cause accessibility issues for screen reader users.Keep up the great work and I hope you enjoyed the challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord