Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Haikal, good job! I took some time to look at your code and have some ideas for improving it:
- add
main
tag and wrap the content of page for improve the Accessibility - use semantic html like
header
,main
,nav
,a
andbutton
insteaddiv
, for more -> read here - to make it look as close to the design as possible use font of challenge for the title
- instead of using
px
try to use relative units of measurement -> read here
Overall you did well 😉
Hope this help and happy coding!
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord