Space tourism website with VueJs

Community feedback

• 

  Bruce B•505

  @bbsmoothdevPosted about 3 years ago

  I would recommend you make all of the clickable elements either links or buttons. This will give you better keyboard accessibility, which only the menu at the top currently has.

  Marked as helpful

  2

  ---

  

  Aliseth•155

  @charlottesaidiPosted about 3 years ago

  @bbsmoothdev Thanks for the feedback and advice, I appreciate it ;) I'll fix this :)

  0
• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 3 years ago

  Excellent work, Aliseth! Bruce made a great point about using links and buttons to help make the UI accessible. For the tabs on each inner page, buttons would be perfect, as you're toggling content instead of navigating to new pages.

  I'd recommend adding min-height: 100vh; to the elements you use to add the background images. At the moment, they cut off early on a lot of the pages, especially at smaller screen sizes.

  I hope that helps. Keep up the great work! 👍

  Marked as helpful

  1

  ---

  

  Aliseth•155

  @charlottesaidiPosted about 3 years ago

  @mattstuddert Thanks for the feedback! You're right, I used links for the destination tabs but button tag is a better choice 👍

  As for the background's height... I wish there was a "marked as extra helpful" button for that advice 😁 Thank you, I've been trying to assign a 100% height to those bodies but I didn't think about "min-height" and vh values ... It's perfect! Thanks!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 3 years ago

  @charlottesaidi, you're welcome!

  0