Frontend Mentor | space tourism website solution coding challenge solution

Solution retrospective

after 30 hours of coding. it's finally done, i applied some hover effects to the navigation bar (when hover on an element, a dot slowly drops from the element and expands to become a whole line, and when mouse it out, the line becomes a dot again and returns back to the element) or at least that's what i was trying to do, if you have some ideas to improve it i'm all ears, i also faced some problem making it responsive

please if you can help me with any of these problems, or any other problem i didn't notice provide me with a feedback thanks for your time.

Community feedback

Abdul Khaliq 🚀• 72,660

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

So fix it by replacing the <div class="main-section"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

space tourism website solution

Design comparison

Solution retrospective

Community feedback

Please log in to post a comment

Join our Discord community