Space tourism website solution Flex, Grid, Components, JS DOM

Community feedback

• 

  Tim Jeanmart•150

  @Tim-jnPosted over 2 years ago

  Great job !

  I think there are size issues in tablet mode on the technology page, content is bigger than the window

  Marked as helpful

  2

  ---

  

  Cacti•390

  @nottohavePosted over 2 years ago

  Hi @Tim-jn , thank you for pointing it out. I fixed the content font-sizes on the technology page.

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Fay, I took some time to look at your solution and you did a great job!

  I see that in the mobile menu has some problems: firefox does not support the css backdrop-filter property, you can add an exception in firefox by putting a solid color there only through @supports, look here:

  • backdrop-filter
  • @supports

  Also try to add a little transition on the element with hover effect

  Overall you did well 😉

  Hope this help and happy coding!

  1

  ---

  

  Cacti•390

  @nottohavePosted over 2 years ago

  @denielden I am not a big fan of copying and pasting comment because I feel like I am talking to a bot. Kevin did address about the backdrop-filter problem on Firefox. My code does have backdrop-filter and @support when I submit them in GitHub. I strongly suggest you read my CSS code and provide a more throughout feedback. It will help you and anyone else become a better developer :)

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @nottohave Quiet you are not talking to a bot 😉

  I saw that in your code you entered @support but in line 347 of your style.css as you can see you rewrote the backdrop-filter property which is executed in any case, so much so that when I looked at your menu it was illegible because applied the filter and was practically transparent.

  Now I see that the background to line 380 changed but as you can see from the developer console you can find just below the class with the backdrop-filter property crossed out. So backdrop-filter must be written exclusively inside @support

  I hope it is clearer now. Keep it up!

  Marked as helpful

  1

  

  Cacti•390

  @nottohavePosted over 2 years ago

  @denielden I will leave the original code be. I think commenting about backdrop filter is not helpful for you and the person doing the project because many of your comments are repeating the same thing over when the @support for backdrop-filter is not working on Firefox. I have also seen a person replied back to this sort of problem from your comment which said the same thing. So I decided to comment the @support backdrop filter out. This is something that Firefox should look at and give an update. I am unsure if @support for other features would work on Firefox because I have not tried it out. But anyways, if this sounds harsh I'm sorry, thank you for looking at my code.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @nottohave No problem :) and happy coding!

  1