Design comparison
Solution retrospective
The most annoying issue with this project was dealing with the backgrounds. Is there a best practice is adding background images that need to change depending React Router outlet?
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Nicholas Blanco, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
The links must have an aria-label or sr-only text that tells where the link navigates the user. For example: Visit our Facebook. For images, you should set aria-hidden=” true” to be ignored by screen readers and to avoid redundancy and repetition.
Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
The rest is great!
I hope it helps... 👍
Marked as helpful1@nablancoPosted about 2 years ago@AdrianoEscarabote Thanks Adriano! This is very kind and helpful. I will take this advice into my next project :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord