Space Tourism using React

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Nabilla, great job! Congratulations on completing the challenge.

  I had a look at your solution and I have a few suggestions for you:

  • in the mobile the menu does not have the background
  • try add transition to the tab element ;)
  • <BrowserRouter> it should be inserted in the index.js by wrapping the app, like this:

  ReactDOM.render(
    <React.StrictMode>
      <BrowserRouter>
        <App />  {/* App or any other component */}
      </BrowserRouter>
    </React.StrictMode>,
    document.getElementById('root')
  );
  

  Overall you did well :) Hope this help !

  Marked as helpful

  0

  ---

  

  Nabilla Trisnani•100

  @NabillaTrisnaniPosted almost 3 years ago

  Hi @denielden. Thank you for your input 😁

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @NabillaTrisnani You are welcome! And don't forget to mark my comment as helpful if helped you :)

  0