Space tourism project with react and react router

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the react's root node <div id="root"> with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Saad Hisham•1,750

  @Saad-HishamPosted over 1 year ago

  Hey there! Congratulations on finishing your project, that's awesome! I'm glad to hear that you feel it's almost perfect, but I'm also happy to share some tips with you to help make it even better.

  One thing I noticed is that there are some issues with the background image not covering the entire body of the page. That can definitely be a bit frustrating! But no worries, it's an easy fix.

  One way to solve this issue is to add the background image to the body element and attach it with a fixed value. Here's an example of how you could implement this in your CSS:

  body {
    background-image: url(/space-tourism/static/media/background-home-desktop.cdf3864….jpg);
    background-size: cover;
    width: 100vw;
    height: 100vh;
    background-attachment: fixed;
  }
  

  By setting the background image to the body and attaching it with fixed value, you ensure that it covers the entire page and stays in place as the user scrolls.

  I hope this tip helps you improve your project even more!

  Keep up the great work and happy coding! ❤️

  Marked as helpful

  1