@MaxTarasevich
Posted
Hi Miguel!
Good job!
Pay attention to the following points:
1.Make the body background color dark to avoid flickering when the page first loads. It takes time to load the image and the body background is white by default.
2.I noticed that you use @import in style.scss. The Sass team discourages the continued use of the @import rule.. You should use @use and @forward.This video also can help you!
3.Tabs on destination page and technology page, slider on crew page - I think you should use JavaScript! Loading a new HTML page every time the slider or tab state changes is a bad idea! Maybe this video can help you with tabs and this video with slider.
4.It seems to me that for multi-page sites it is worth using PUG instead of HTML, this will significantly speed up the development process, of course you will also need GULP or WEBPACK to automate work with PUG, SASS and other routine tasks.
I hope my feedback will be helpful!
Marked as helpful
@migueldeleon012
Posted
@MaxTarasevich
Hi Maksim!
Thank you for the feedback! i will now refactor my code.