Design comparison
SolutionDesign
Solution retrospective
Hey there, so I had retry this challenge after 7 months from my first version which was trouble, I tried my best in this website and followed the design system and applied it 90% the 10% rest I prefered to put my own touch, so maybe you gonna find some things diffrient from the original one but it is pretty good and well designed for most screens, I hope you like it and I will really appreciate any feedback about it or any bug you found in it, Thank you.
Community feedback
- @ChamuMutezvaPosted about 2 years ago
Hi Mohammed Kasim
So far so good with your project , but with some adjustments that are needed.
- The site is not generally responsive , most content is cut off and at times can only be viewed by scrolling sideways. You need to review your css and would suggest to practice the mobile first approach when styling, that means your base styles will generally target mobile phones then add a media query (use min-width instead of max-width) when there are signs that layout or any other signs start breaking
- Heading elements should follow a sequential order with the heading h1 element being the first heading element of a page . Find out more on the MDN site heading elements
- this
<h3>EXPLORE</h3>should have been a button , not a heading element. Using semantic elements is very important, for the destination page the list ofmoon, mars, europa, titanshould have some interactive element (anchor) as a child element. - using the text provided other than the lorem text is something that i would recommend
Happy coding
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord