Space tourism multi-page website

Community feedback

• 

  Vlad•240

  @vladmeePosted over 1 year ago

  Looks great! You followed the design almost 1-on-1. Even added an animation to display the destination content. That's impressive!

  I see you successfully displayed different portrait or landscape images using media queries, anything you want to ask about that?

  I like the image slider on the crew page. That's a nice touch. I would like to suggest something here. For the images instead of object-fit: cover I would add contain:

  .image img {
  
  object-fit: contain;
  
  }
  

  In this way, you make sure the image is not being cropped out, especially here where you are displaying portraits of people. I know that you already added object-position: top; which makes sure their heads are never cropped out (which is very thoughtful!) but you should always aim to display the data in the best possible way!

  On another note, I think you overengineered the mobile nav. Using context is not fully necessary, you can handle the toggle with a simple useState inside the component. Unless.. you wanted to practice context in which case everything is neat!

  Oh, before I hit send, you forgot to add the interaction for the EXPLORE button on the homepage. It should have a pretty nice animation on hover too.

  Looking forward to seeing your updated solution! Practice makes it perfect!

  Marked as helpful

  1
• 

  Jamie Big•580

  @jamesekunolaPosted over 1 year ago

  "I've incorporated animations for the explore button and the rest of the page. However, I'm encountering a problem on mobile devices where there is overflow on both the horizontal and vertical axes, even though I've applied {overflow-x: hidden} to the body. I would greatly appreciate any advice or suggestions on how to resolve these issues."

  0