Space tourism multi-page and responsive website

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 2 years ago

  Hey @hebrerillo, this looks visually solid, congrats!

  The only thing that I noticed is the use of semantics, especially headings, on each page. We're missing the h1s here and the heading levels doesn't seem to be in order (ex. h5 is mentioned first before h2). Use classes to style your headings (or anything for that matter), instead of looking at 'how large' they look on the design and assigning a heading tag. Here's a resource regarding the headings.

  Hope this helps!

  Marked as helpful

  1

  ---

  

  hebrerillo•350

  @hebrerilloPosted about 2 years ago

  @emestabillo thank you for your feedback!!

  I only had the 'h1' tag in the home page but was missing in the rest of the pages. Now I added the 'h1' tag in the rest of the pages.

  I also updated the order of the headings. For example, now 'h3' tag is before 'h4' tag. Is that what you meant?

  I made a commit with your suggested changes. Could you please take a look?

  Thank you so much!!

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 2 years ago

  @hebrerillo seems better, yes. It's best-practice, however, not to skip heading levels as stated in the resource I mentioned above. You can reuse the heading tag once it's been mentioned once, in order.

  For example, in the technologies page, you have h1> h4 > h3. The numbers are not in order. Ideally, it would be h1> h2 > h3. You can then reuse h2 and h3 elsewhere in the page as long as it has been mentioned in order once, ex. h1> h2 > h3 > h2 > h3 > h2. This semantic is common in designs that have multiple sections, since each of the sections will usually need the same headings.

  Another side note about the h1 on the homepage. I would keep the entire phrase 'SO, YOU WANT TO TRAVEL TO SPACE' in one h1 tag. I would write it as <h1>SO, YOU WANT TO TRAVEL TO <span>SPACE</span></h1>.

  Hope this helps!

  0