Design comparison
Solution retrospective
Any feedback is welcome.
Community feedback
- @BlackpachamamePosted 10 months ago
Your solution is great! It's very good, but I'm afraid that by defining
overflow: hidden
in yourbody
it cuts the content on some pages and doesn't allow you to scroll to see the rest.0@SuayipEmrePosted 10 months agoThanks for your feedback @Blackpachamame. Did you notice any issues with the scroll process? Because overflow: hidden only applies to desktop screens. If you encountered any issues, could you specify the specific page and pixel value?
0@BlackpachamamePosted 10 months ago@SuayipEmre My screen has a width of 1366px and a height of 768px (in the browser it is a little less, about 600px for the navigation bars). In the same element inspector it is seen cut with the width of 1440px and height of 833px. Screenshot of my screen
How do I know it's because of the
overflow: hidden
? Well, by disabling this property it now allows me to scroll without problems.0@SuayipEmrePosted 10 months ago@Blackpachamame I understand, can you try again? The scroll should be working now.
0@BlackpachamamePosted 10 months ago@SuayipEmre I was able to see all the pages well except the home page. I found a few things:
.h-screen { height: 100vh; }
You should always use
min-height
as this allows the content to extend if necessary.There is still an
overflow: hidden
although I don't know if it affects anything#home_screen_container { overflow: hidden; }
0@SuayipEmrePosted 10 months ago@Blackpachamame No, you shouldn't always use min-height. Especially on larger screens, if your content is defined and there's no need for scrolling, min-h-screen may not be necessary. Min-height is generally more useful on mobile screens. Additionally, it's not needed on larger screens depending on the content.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord