Design comparison
Community feedback
- @JohndiddlesPosted over 2 years ago
Hi Sboon! Really nice work you have done here.
I see you use grid for for most of the main contents. That's great. I feel you could actually use 2 columns instead of four and add some gap between the columns. You could do that by add
gap: xem
where x could be any number (even decimals). You could give the parent container some padding on the x-axis so that the columns don't stretch to the ends of the screen's width.Otherwise, everything seems great.
Nice work again. Cheers 🍻 🥂 and happy coding...
Marked as helpful1 - @Jay-0331Posted over 2 years ago
Hello, Great Work Man. just one question in mobile why is there a line in top left corner. other than that everything works great.
Marked as helpful0@SboonnyPosted over 2 years agoHello @Jay-0331, it's skip-to-content button not transforming fully
.skip-to-content { position: absolute; z-index: 9999; background: hsl(var(--clr-white)); color: hsl(var(--clr-dark)); padding: 0.5em 1em; margin-inline: auto; transform: translateY(-100%); transition: transform 250ms ease-in; }
. I have yet to tackle that issue. but it will be fix in future, thanks for pointing it out. 🥰
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord