Space Tourism

Community feedback

• 

  Zineb Boutaa•750

  @zineb-BouPosted about 3 years ago

  Hi Ashraf,

  Your solution looks good, I am dropping some notes that may help you even further.

  • Make your logo image aria-hidden: true, letting the image be exposed to the screen reader, it will read the image source path, and don't forget to add alt=" page logo".
  • On the home page, "so you want to travel to space" it's all considered as an <h1>, you can use <span/> to divide the title into two different sections so you will be able to style them differently.
  • the same remarque about other pages, don't use <p > for titles use <h2> instead, and your website should only contain one <h1> tag
  • explore I think it's not meant to be for decoration, it's actually a link that will lead the user to a different page to see more options, so don't make it an <div> it's <a>
  • All of your slide progression controls need to be buttons, not links or divs, as they perform an action on the same page.
  • don't add images without adding any alt to it, it's helpful for all users, imagine there is a problem in image loading, alt would provide a description about the image, even if the user won't be able to see it.

  Marked as helpful

  0

  ---

  

  Ashraf Essaoudi•280

  @ashrafess00Posted about 3 years ago

  @zineb-Bou thank you so much, your comment is so helpful and i will edit the project tomorrow considering your notes of course I hope you a great day 😊

  0