Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Some Youtube videos

Sofia 40

@Escobar23

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am new to this, I would appreciate the feedback!

Community feedback

Manuel Gil 340

@ManuGil22

Posted

Hey @Escobar23 good job with the challenge!

Just some details to check:

  • Try to decrease the margin-top for the .card, 200px seems like too much and if u check it on the phone u will see its a lot of margin. Maybe u can try with margin-top: 8rem
  • Add a <main> tag around the div with card class to solve the accessibility issue.

Everything is just perfect, dont worry about the sizes of the card, there are just details and u will improve it for sure!

Keep pushing and happy coding!

Marked as helpful

0
Saul 1,260

@xsaul

Posted

Hello Sofia, is a really good job! I think the <h2> font size should be a little smaller, and add some margin to the bottom of the card. Besides that everything looks really good!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord