Some feedback will be amazing :)

Community feedback

• 

  Shraddha•485

  @5hraddhaPosted almost 3 years ago

  Hey @Markizzo, Good job on implementing the design. 👍 There are a few suggestions to improve upon:

  1. I appreciate that you have used <header>, <main> and <footer> semantic elements. But, you could improve further by using <section>, <article> and <ul> tags. It gives better meaning to the markup and improves accessibility. Freecodecamp Semantic Elements. For more clarity on nesting of HTML elements semantically, you could refer this article - CSS Tricks - How to section your HTML Elements. I usually refer this when I am confused which elements should be nested in which ones.

  2. Also, it is good to give a meaningful value to alt attribute of <img> tag.

  3. It is good to have an understanding that <div> is a container tag. And it should not be used for writing headings and paragraphs. You have <h1>, <h2>, ..., <h6> tags for headings and <p> tag for paragraph. You could correct the usage of tags in cards.

  4. In footer, you have a list of links (both social icons and texts), you have to give them in <a> tags with proper value of href attribute pointing to a meaningful URL.

  5. For every even no. card, the position of image is reversed in the design. You could achieve this using flex box's property flex-direction as row-reverse.

  Thank you!!

  Marked as helpful

  2

  ---

  

  Mark Wasfy•280

  @MarkWasfy00Posted almost 3 years ago

  @5hraddha Thank you alot for the feedback i really appreciate your notes , yes i gotta put more work in html symantic , thanks again ! have a good day :)

  1
• 

  Shraddha•485

  @5hraddhaPosted almost 3 years ago

  It is my pleasure @Markizzo. Take care..

  Marked as helpful

  0