Design comparison
SolutionDesign
Solution retrospective
This is my first solution and I'm very excited to see what kind of feedback I would get from everyone. Here are a few things I would really like to know:
- Please let me know if there is a better solution to this problem.
- I'm very unsure of my css code organisation. Is css code usually written in a particular order? If so, please let me know how I can organise my css code better.
- I would realy appreciate if someone could tell me what milestones are good to make git commits. Also, how would I write commit messages.
- Have I made any mistakes? If so, please let me know.
- If there was something you noticed in particular about my project, please let me know. *All the feedback I will receive will be deeply appreciated.
Community feedback
- @oshudevPosted over 2 years ago
Hi Varun Sharma, great job!
Add the
main
tag and wrap the card for Accessibility. It should be like this:<body> <main> <div class="card"></div> </main> </body>
Overall you did well! Hope it helps.
Marked as helpful1@varunsharmablogPosted over 2 years ago@eurus1108 You definitely taught me something new. Thankyou :) I'll be learning more about accessibility as I move forward in my journey.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord