Solutions qr code component

Community feedback

• 

  Lucas 👾•104,220

  @correlucasPosted over 2 years ago

  👾Hi Esteban Cortes, congratulations on your solution!👋

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.Add the alt text to improve accessibility.The alt attribute provides alternative information for an image if a user for some reason cannot view it (because of a slow connection, an error in the src attribute, or if the user uses a screen reader). ---> <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor">

  2.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  3.To maintain the card responsive use max-width instead of width this way you allow the content to be flexible. The difference between max-width and width is that width is fixed and max-width has a maximum size but can shrink to fit the content.

  4.Use relative units like rem or em instead of px to have a better performance when your page content resizes on different screens and devices. REM and EM does not just apply to font size, but all sizes as well. To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Esteban Cortes R•30

  @ecortesclPosted over 2 years ago

  hello, ismael, thank you very much for your comments, I just applied the changes and now it seems much more :)

  1
• 

  Ismael Barea Insua•40

  @quantoshPosted over 2 years ago

  Hi Esteban, what about puting more margin/padding on the text?, also take a look on the text color, I just made the same mistake today 😅

  Keep coding 👾

  0