SOLUTIONS of QR code component

Community feedback

• 

  M•940

  @Dev-MV6Posted 7 months ago

  Hi there 👋, congrats on completing this challenge, you did an excellent job. Your solution looks great.

  Just one small suggestion. You can use the position property to position your .attribution element absolutely so it doesn't take up any space:

  .attribution {
    /* padding: 80px 50px 0px; */
    /* margin: 80px 50px 0px; */
    position: absolute;
    bottom: 40px;
  }
  

  https://developer.mozilla.org/en-US/docs/Web/CSS/position#absolute_positioning

  Overall your solution looks really good. I hope you find this helpful, let me know if you have any questions, I'll be happy to help 👍

  0

  ---

  

  Eunila•50

  @EunilaPosted 7 months ago

  @Dev-MV6 thanks it really help me .i used margin & padding and i also confused that is it the good practice and now i understand , again thank you for your valuable feedback

  1

  

  M•940

  @Dev-MV6Posted 7 months ago

  @Eunila I don't think using padding would be appropriate for a case like this, but there's no problem with using margin to set the spacing between your elements (not a bad practice at all).

  My suggestion was to simply to position your .attribution element absolutely so you don't have to worry about the card not being centered. But don't get me wrong, you should definitely use margin whenever you need to set spacing between 2 elements.

  I just gave you the position tip because I think that would make your solution perfect, even tho it is very accurate already.

  In any case, I'm really glad it helped you, let me know if you have further questions.

  0

  

  Eunila•50

  @EunilaPosted 7 months ago

  thank you 🥰🥰🥰 for your valuable advice i will remember it @Dev-MV6

  1