Skip to content
Submitted about 2 years ago

Solution with Flexbox

Christina•20
@tinalr
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

The most challenging step was centering the QR code card vertically on the page. I wanted to use CSS Flexbox, and tried several methods, but ended up just using a margin-top to make it looked more centered. Does anyone know what I missed in trying to center .card?

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @tinalr, Congratulations on completing this challenge!

    Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

    Your solution is great and the code is working, but the HTML structure can be reduced by removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading, and paragraph.

    Here’s one example to show can be cleaner this HTML structure:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    To reduce the CSS you can use the direct selector for each element instead of using class this way you have a code even cleaner, for example, you can select everything using the direct selector for (img, h1, and p, main).

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @tinalr

    Regarding you problem, you were heading in the correct direction all, you were missing was the min-height: 100vh. Once you do, you can then remove the margin-top.

    Some suggestions to improve you code:

    • To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
      <body>
    <main>
      <article class="card-container”>
      </article>
    </main>
  </body>

    The Main Element identifies the main content of the document.

    While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.

    More info:

    https://web.dev/learn/html/headings-and-sections/

    • To make your card responsive change the width to max-width.

    Happy Coding! 👻🎃

    Marked as helpful
    0
  • tbahd•160
    @tbahdPosted about 2 years ago

    Hey, @tinalr In regards to centering vertically, you can either add a height of 100vh to your body or wrap your card div in another div/sematic element flex that and add align items to it.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord