Design comparison
Community feedback
- @ZozobrackPosted over 1 year ago
Overall, the code for the front-end mentor project looks good. Here are a few suggestions for improvement:
HTML structure: Consider wrapping the form inside a section or a div with a class, instead of directly putting it inside the main tag. This will make it easier to style and manage.
CSS: Consider using more descriptive class names instead of generic names like 'text' or 'card'. This will make it easier for someone else to understand your code and make changes later.
Responsive design: The current CSS seems to be responsive.
JavaScript: Good job on using event listeners and preventing the default form submission behavior. One suggestion is to add error handling in case the user doesn't select any rating before submitting the form.
Overall, great job on the project and keep up the good work!
1@albina0104Posted over 1 year ago@Zozobrack thank you for your feedback!
Regarding error handling - as the input field has the "required" attribute, the user simply cannot submit the form without selecting the rating, so no error occurs.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord