Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Solution using plain HTML and CSS

@prchristie

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Theres a weird issue when I reduce the screen size to very small horizontally the background (body and main elements) stop taking up 100% of the screen even though I have them both set to 100% height. I've tried setting width to 100% as well but it didn't do anything.

Community feedback

P
Jacksen 350

@jacksen30

Posted

@prchristie great work on this challenge it looks amazing !

As for your weird responsive resizing issue with background ect, I can't explain why it happens but it's a common thing I've found. I've check your site in my browser and from what I can see it only happens at sizes that are so small / narrow you wouldn't encounter a screen that small in real world usage, so I would not stress at all on this!

A couple of bits of constructive criticism I have is:

1- My thinking on a component of this size is that so many css files are unnecessary and actually make it harder to read what is happening, could all be combined in to one... just my personal opinion.

2- I didn't notice any css reset. Its always good to use a css reset as the first selector in your stylesheet such as something basic like this:

* {
    padding: 0px;
    margin: 0px;
    box-sizing: border-box;
}

or for something more advanced you could look at this Josh W's Css Reset

Different browsers use different default margins, causing sites to look different by margins. The * means "all elements" (a universal selector), so we are setting all elements to have zero margins, and zero padding, thus making them look the same in all browsers.

Please mark this answer as helpful if it is, Happy coding

0

@prchristie

Posted

@jacksen30 I linked to the wrong part of my github repository. I have updated it now. I have a css reset linked in the html. I only have the one css file thats mine and I am importing the reset online.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord