Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Solution using only grid

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@NotNotEvan

Posted

Hello!

Overall, nice job on the challenge! A few things to consider:

  • Try to avoid hardcoded heights/widths - you could reduce a lot of your CSS code by using display: flex instead of a grid layout.
  • Avoid px for properties like font-size and letter-spacing - here's a great article on why. The BLUF is, using rem instead will respect the user's font preferences.
  • One small nit - You're missing some bottom padding on the card. Obviously not a huge deal, but if you're trying to go for the exact same design, I would recommend adding that.

Great work. Keep going!

  • Evan

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord