Design comparison
Solution retrospective
Any feedbacks are highly appreciated.
Thanks in advance!!
Community feedback
- @grace-snowPosted over 3 years ago
Hello
Check your html a- I thought you have a closing h2 tag that should be a paragraph (?)
This form looks good. I think the js could be a lot simpler, but it all works fine.
There is a great opportunity on this challenge to improve accessibility skills
- label every input
- link the error messages to their inputs with aria-describedby
- use aria-live on error messages so they are announced by screenreaders
- either move error icons to background images / pseudo elements or empty the alt value on them
I hope these tips trigger you to learn more. God luck
Marked as helpful0@abhineetkandelePosted over 3 years ago@grace-snow Thanks a lot for taking your time to mention the improvements that can be done.
I have done all the changes as per your helpful comments.
0 - @palgrammingPosted over 3 years ago
In a 1000px wide browser window to 1200px wide your layout needs to white space on the left and right of the layout
Marked as helpful0@abhineetkandelePosted over 3 years ago@palgramming Thanks for noticing that. Fixed that.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord