Solution using flexbox

Community feedback

• 

  Arshad Ali Kaldane•650

  @IamArshadAliPosted about 1 year ago

  Hi there, 👋

  Congratulations on completing your first challenge. 🎉

  As for feedback, I would suggest using semantics to improve your code structuring.

  For example:

  • Wrap your .container class in <main>...</main> instead of <div>...</div>
  • Use <footer></footer> for .attribution
  • Wrap 'Challenge by ...' and 'Coded by ...' in a <p>...<a>...</a></p>

  And provide a class or id to identify and style each element. This will make your code much readable.

  For example:

  <div class="qr-card">
    <img  src="..." alt="..." class="qr-card__image"/>
    <h1 class="qr-card__title">...</h1>
    <p class="qr-card__desctiption">...</p>
  </div>
  

  Note: This technique of giving names to classes is known as BEM (Block Element Modifier)

  There is a lot more ahead. Keep up the great work, and don't hesitate to reach out if you have any questions or need further assistance. 🤝

  Happy coding! 🤓

  0