Design comparison
SolutionDesign
Solution retrospective
- What did you find difficult while building the project?
Determining the styles based on the image. Shadow and border radius wasn't provided in the style guide.
- Which areas of your code are you unsure of?
None at the moment
- Do you have any questions about best practices?
Tailwind config in the script tag. Unsure whether there's a cleaner way to do things.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports due to
non-semantic
markup
- So fix it by wrapping the whole content the with semantic element
<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark elements ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
HEADINGS ⚠️:
- And, This solution generates accessibility error reports due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
IMAGE :
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose.
- e.g.
alt="QR code to frontendmentor.io"
I hope you find it helpful ! 😄 Above all, the solution you submitted is great
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord