Solution using flexbox

Community feedback

• 

  Hanif•570

  @1Hanif1Posted almost 3 years ago

  I tried to look at your code but the git hub link is broken As per what I see on the console first thing I'd say is don't set solid width and height to 'body' instead just put "min-height: 100vh" on body. It'll automatically make the body span the entire window

  Also your card is not centered. Centering elements is tricky so here's one way to do it set the container class of your card to have the following properties { display: flex; justify-content: center; align-items: center; }

  If you're not familiar with this code then I'd suggest you look into Flex box in CSS

  considering you're a beginner I'll share a resource from where you can learn CSS in depth https://web.dev/learn/css/

  Finally some bit of motivation! Great work! Keep trying and happy learning! ^^

  1

  ---

  

  Haim Mizrahi•30

  @haimmmPosted almost 3 years ago

  @1Hanif1

  Hi thanks for the tips, the git link is ok now! This is my first challenge, i followed the style readme and it says "Desktop: 1440px" so i thought i have to change the body width to that...

  0
• 

  erdo•50

  @IDerdiPosted almost 3 years ago

  body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }

  0