Design comparison
Solution retrospective
What would I do differently next time I think I did a bad job of changing the time values there's probably a better way to change them other than making a function for each card.
Community feedback
- @0xabdulkhaliqPosted 7 months ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have a suggestion regarding your code that I believe will be of great interest to you.
CSS šØ:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
.
- We don't need to use
margin
to center the component both horizontally & vertically. It will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here š.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
#main { margin: 2% auto; } @media (min-width: 400px) { #main { margin: 8% auto; } }
- Now your component has been properly centered
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
0 - @danielmrz-devPosted 7 months ago
Hello there!
Congrats on completing the challenge! ā
Your project is looking fantastic!
I'd like to suggest a way to make it even better:
- Using
margin
isn't always the most effective method for centering an element.
Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:
š Apply this CSS to the body (avoid using
position
ormargins
in order to work correctly):body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
I hope you find this helpful!
Keep up the excellent work!
0 - Using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord