Solution using CSS Grid and Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • If you want to have a responsive component that resizes, you should use max-width: 320px on the component instead of fit-content, then use max-width: 100% on the image so that the edges don't get cut off on mobile devices.

  • Use min-height: 100vh instead of height: 100vh. The height property can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Elhabib TOUAOUA•50

  @ElhabibTOUAOUAPosted almost 2 years ago

  Hello @MelvinAguilar, I hope you are doing well. Thank you so much for your suggestions, they were very helpful specially the max-width property that I wasn't aware of the true potentials of it.

  Thanks again, and I hope to see your feedback more often.

  best regards.

  1