Design comparison
SolutionDesign
Solution retrospective
- What I found difficult was going again through the process of learning CSS and HTML concepts.
- I'm unsure about good practices of using CSS flex and positioning.
- Just wanna know alternatives of positioning child elements within their parents.
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Carlos Ng, It looks good! but you have some
issues
you need to fix.All page content should be contained by landmarks
, Sodocument should have one main landmark
, Contain the component in<main>
...</main>
.Page should contain a level-one heading
, Changeh2
toh1
You should always have oneh1
per page of the document.- This
<p>Cancel order</p>
Should be a button to cancel the order when clicking on it, not a paragraph - This
<span class="change">Change</span>
should be an anchor link, not aspan
<main> <div class="background"> <div class="card"> <div class="card-header"></div> <div class="card-content"> <h1>Order Summary</h1> <p> Lorem ipsum dolor sit amet consectetur adipisicing elit. Dolore fugit nemo recusandae nam enim! Facere cupiditate iste id perferendis praesentium similique rerum ea vitae aut?</p> <div class="plan-container"> <i class="m-icon"></i> <div> <span class="title">Annual Plan</span> <span class="sub-title">$59.99/year</span> </div> <a class="change" href="#">Change</a> </div> <button> Proceed to Payment </button> <button>Cancel order</button> </div> </div> </div> </main>
I hope this is useful to you... Keep coding👍
Marked as helpful1@ahmed-abdatPosted over 2 years ago@Bayoumi-dev Hello Brother I have question can I use a instead of button !
and thank you that comment it is helpful
0@Bayoumi-devPosted over 2 years ago@ahmed-abdat It depends on what you want to happen after clicking on "Cancel order" ... will it redirect the user to another page or section? Use
anchor link
<a>
Otherwise, use thebutton
Buttons
are used for actions like opening or closing something, or sending a form.Links
are used for navigation and actions.
Marked as helpful2@carlosngvPosted over 2 years agoThanks @Bayoumi-dev Appreciate your feedback! I'll take note of your suggestions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord