Solution to Tip calculator app challenge

Community feedback

• 

  Shuaib•640

  @JustShuaibPosted over 2 years ago

  Hi there, I noticed from your solution that the input-people displays can't be zero when either of the input field is filled. You can work on it to make it display can't be zero only when the input entered into it is zero.

  Also, the two inputs have a green border on hover. Instead of hover, you could use focus. Really nice work I must say 😊

  0

  ---

  

  firdaussmsudin•110

  @firdaussmsudinPosted over 2 years ago

  @JustShuaib Thanks for the feedback. Yes I think is the best to only display can't be zero only when the input entered. Will be do it later.

  About the hover, should we indicate that the input can be entered by making it to have green border when hover? It do have focus when user entered the value there.

  0

  

  Shuaib•640

  @JustShuaibPosted over 2 years ago

  @firdaussmsudin Hi, sorry for the late reply, I've been away. What I meant was that instead of giving it hover and focus, you should give it only focus. The hover is kind of distracting.

  0

  

  firdaussmsudin•110

  @firdaussmsudinPosted over 2 years ago

  @JustShuaib Hi, it's okay. Thanks for the reply. I see. Okay thank you for your insight.

  0