Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Solution to the Social links profile using Flexbox(easy to understand)

Yujan Bajagainβ€’ 170

@GamingClaus

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

To be honest i am proud of my work overall. and i am hoping to try use different layouts next time.

What challenges did you encounter, and how did you overcome them?

I didn't encounter many problems while doing this challenge as my previous challenge helped me learn a lot and I fixed those problems here.

What specific areas of your project would you like help with?

If there are anything i need to improve please let me know

Community feedback

Dylan de Bruijnβ€’ 3,190

@DylandeBruijn

Posted

@GamingClaus

Hiya! πŸ‘‹

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • Try using semantic HTML elements like main, section and article.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • Try putting your links in a list (ul) to make your code more semantic. I also suggest using a tags instead of a button for you links.

  • You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result.

I hope you find my feedback helpful! 🌟

Let me know if you have more questions and I'll do my best to answer them. πŸ™‹β€β™‚οΈ

Happy coding! 😎

Marked as helpful

0
Borisβ€’ 2,870

@mkboris

Posted

Hi GamingClaus nice work, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around .main-wrapper.
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content.
  • Using a list ul to group the social media links is a better approach for both semantics and accessibility.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Media queries should be defined in rem not px

Hope this helps

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord