Solution to the Social links profile using Flexbox(easy to understand)

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @GamingClaus

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • Try using semantic HTML elements like main, section and article.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • Try putting your links in a list (ul) to make your code more semantic. I also suggest using a tags instead of a button for you links.

  • You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result.

  I hope you find my feedback helpful! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0
• 

  Boris•2,850

  @mkborisPosted 4 months ago

  Hi GamingClaus nice work, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around .main-wrapper.
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content.
  • Using a list ul to group the social media links is a better approach for both semantics and accessibility.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Media queries should be defined in rem not px

  Hope this helps

  0