Design comparison
Community feedback
- @kevorklepedjian1Posted 12 months ago
Congrats on the work. It looks good, i would advise you to style the text like the one in the design with the help of padding, other than that it looks awesome
Marked as helpful0 - @pmigixPosted 12 months ago
Congrats on tackling the challenge!
I might have some useful suggestions you can play around with!
1.Don't wrap content in unnecessary div tags, you've already done a great job of wrapping your content in separate sections, get rid of
<div class="image-container">
and<div class="info-container">
2.Your image shrinks before hitting the breakpoint, so to make image fill up the section add additional properties to your
.desktop-img { height: 100%; object-fit: cover; }
and try setting the breakpoint at768px
3.To stop your content from continuously growing on larger screens, on your
.main-container
instead of setting thewidth:50%;
, trymax-width:40rem;
I hope any of this helped in some way. Best of luck in further challenges!
Marked as helpful0 - @emmeceePosted 12 months ago
Thank you! I still struggle to structure my html, this really helped alot.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord