Solution to the article preview component, using SCSS and vanilla JS

Community feedback

• 

  Jordane Gengo•590

  @jgengo-altPosted over 2 years ago

  Hello there 👋

  First of all, great job 🚀 I really like your addition of the small border on the share button, it gives the vibe of being button compared to the very flat one the preview design. Also, your grid is nite!

  However, I noticed a small issue with your solution: your social media buttons are clickable even if not displayed, you should use a display: none; and toggle it instead of an opacity: 0;

  More a UX than UI feedback, but

  • in mobile version, the translation of the share from the bottom to the top would be better than the left to the right 🪴
  • in desktop version, I feel like the button share could toggle instead of having the hover effect: when tooltip display button dark, when not light. 🌱

  Once again, great job!

  Keep going 💪

  Don't hesitate to follow me on and give me feedback on my assignments! I will follow back and keep giving you feedback if you are interested for your future publications.

  Marked as helpful

  1

  ---

  

  Julian Florez•190

  @juliflorezgPosted over 2 years ago

  @jgengo-alt Thank you so much all those observations are really useful, definitely will work on that!!

  0