Solucion a la landing page de la agencia Sunnyside (CSS GRID, FLEXBOX)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Olá, Daniel Solis! 👋

  Well done on this challenge! 👍 Your solution looks great and scales up/down nicely! 👏

  I suggest,

  • Taking a look at your solution report and trying to clear up some of the errors that are there in order to improve the accessibility of your solution (looks like you need to as some alt text to the images).
  • Adding object-fit: cover to some of the images in the desktop layout to make sure that they are clipped (not stretched or squeezed) when their size changes.
  • Adding a favicon to the site (there's one in the free starter files for the challenges that you can use).
  • Adding the mobile menu toggle button (as Amon mentioned). 😉

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0

  ---

  

  Daniel Solis•70

  @d4ndynoobPosted over 3 years ago

  @ApplePieGiraffe Thank you very much for your suggestions, I have put them into practice and I already found the arrow icon in the files, I also added object-fit: cover; and the images now look much better. For the moment I will continue working on the button in the navigation bar. Thank you very much again

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @DanielSolis14

  No problem, Daniel! 😀 I'm glad to help. 👍

  0
• 

  Amon•2,560

  @A-amonPosted over 3 years ago

  Its good! But the menu button seems to be unavailable on mobile size~

  Marked as helpful

  0

  ---

  

  Daniel Solis•70

  @d4ndynoobPosted over 3 years ago

  @A-amon Thanks for comment. It's true! I forgot to add a button to open the navigation bar from mobile devices. Thanks, I'll work to correct that!

  0

  

  Amon•2,560

  @A-amonPosted over 3 years ago

  @DanielSolis14 No prob!

  0