Solution to QR code excercise

Community feedback

• 

  Agnar•220

  @agnar-nomadPosted about 2 years ago

  Hey Nicola,

  Good job on the solution!

  As Alex mentioned, make sure to adjust the size of the card compared to the document body and adjust border radii. I believe you wanted to use margin on the main element instead of body.

  Take a look at the font-size ratio between <h1> and <p> in the design. Yours does not match it. I think using <br> is the best way to distribute your lines. Rather consider setting max-widths on the proper block elements, which also helps with responsiveness later when building mobile layouts (if thats what you build in the later stages)

  Marked as helpful

  1

  ---

  

  Nikola•30

  @Nikola-MiticPosted about 2 years ago

  @agnar-nomad Thank you

  0
• 

  Alex Salgado•50

  @alexgsalgPosted about 2 years ago

  Hey Nikola, Just some quick tips that I noticed, but overall you did a nice job.

  • One thing is the scale was a little bigger compared with the design provided but with the right proportions;
  • You styled the body with margin: 2rem; and height: 100vh; which creates a scroll on the screen, margins are spaces outside the block, in this case, use padding instead
  • Just an opinion: all the structure styles(display, justify-content...) you placed on the Body you could have placed on the <main> tag.
  • Last one, on the card the border-radius could be a little higher to match the design.

  Marked as helpful

  1

  ---

  

  Nikola•30

  @Nikola-MiticPosted about 2 years ago

  @alexgsalg Thank you

  0