@Stroudy
Posted
Hey great job getting it so close to the original, some things I noticed,
- Your
<html>
tag does not have a lang attribute like this<html lang="en">
This will add accessibility to your site. - Missing a
<meta>
description tag for SEO purposes - It is best practice to have a
<main>
tag inside your body highlighting the main section. - For your
.attribution
selector usingdisplay: absolute
is not a good idea as it moves unintended on different screen sizes. - Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
Marked as helpful
@CAF2801
Posted
@Stroudy
Thank you for the tips ! I will check this out for sure !