@DylandeBruijn
Posted
@GamingClaus
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
You donβt have to wrap your image in a separate
div
, itβs possible to style it directly to achieve the same result. -
You don't have to use negative margins to layout your elements. Negative margins do have their place when developing websites but I recommend not using them how you used them in this project.
-
I recommend using a
p
tag for "Learning". -
To prevent an
img
tag from overflowing you can addmax-width: 100%
to it.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful