Design comparison
SolutionDesign
Solution retrospective
Hello, This is my first challenge
Community feedback
- @Jithin-b-pPosted 10 months ago
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
In the html try using semantic tags for accessibility use <article> for every testimonial, put the quote paragraph in a <blockquote> tag.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1 - @BlackpachamamePosted 10 months ago
¡Buen trabajo Ingrid!
Siguiendo con los temas de semántica, puedo comentarte lo siguiente:
- Tu
div
con clasetestimonial-grid-container
debería sermain
- Tu
div
con claseattribution
debería sermain
- Tenes algunos
article
encerrados en unosdiv
y otro suelto. Entiendo la lógica para ordenarlos, pero, no sé si sea la mejor forma, ya que quedan en distintos niveles en tu HTML
1 - Tu
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord