Design comparison
Community feedback
- @ThaBeanBoyPosted about 2 years ago
Hi @Rhythm001, I checked out your project, I like what you've done so far. I'd like to suggest a few things that could make your life easier when developing sites. Please bare in mind that I'm not a web developer by profession, these are just my opinions & suggestions.
It seems like the container class doesn't have a max-width property, the reason I bring this up is that I fear that on wider screens, your site won't be as presentable. Here's a resource you can check out if you want to learn more about max-width CSS property: https://www.w3schools.com/cssref/pr_dim_max-width.asp
Personally, I'd use flex-box on the container class. The reason I suggest flex-box is because it makes CSS easier to work with, like in this project. I don't even know when I last use the float property (Like you did with the image). Another reason I suggest flex-box is that it makes it easier to make things responsive, which leads me to my next point. flex-box resource : https://www.w3schools.com/css/css3_flexbox.asp
The site isn't responsive. When the screen is approximately 1368px wide, the project looks like the design, unfortunately, not all users have a screen that's approximately 1368px wide, so we have to take into account a variety of screen sizes. the site breaks when you start making the screen smaller. Here's a cool resource you can learn about responsive design: https://www.w3schools.com/css/css_rwd_intro.asp
I hope my comment is useful, & the resources I provide you are useful too. Hopefully we will keep learning so we can improve our web dev skills.
1@Rhythm001Posted about 2 years ago@ThaBeanBoy Hey, sorry for the late reply. At the time when I did this challenge, I had no idea about containers. So, what you were suggesting me, seemed like some complex topic. Now I understand your suggestion and realize my mistakes. Thank you.
0 - @correlucasPosted about 2 years ago
👾Hello @Rhythm001, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the
<picture>
tag instead of importing this as an<img>
or using a div withbackground-image
. Use it to place the images and make the change between mobile and desktop, instead of using adiv
orimg
and set the change in the css withdisplay: none
with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device desktop + mobile.Check the link for the official documentation for
<picture>
in W3 SCHOOLS:https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture> <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;"> </picture>
👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1
✌️ I hope this helps you and happy coding!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord