Design comparison
SolutionDesign
Solution retrospective
I need to improve the responsiveness and media query more, but I'm learning more and more.
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @Dago04!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful1@Dago04Posted 10 months ago@danielmrz-dev Thank you very much for the recommendation, I'm still learning the best ways to make responsive designs, I really appreciate your comment, I think I used Grid to center the container but i didn't apply it to the body instead, anyway all tips are welcome.
1 - Using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord