Design comparison
Solution retrospective
GIVE ME FEEDBACK!!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semantic
markup, which causes lacking of landmark for a webpage
- So fix it by replacing the
<section class="back">
element with the semantic element<main>
along with<div class="attribution">
into a<footer>
element in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0 - @chill31Posted over 1 year ago
Main problem is the font, it's not in use anywhere.
In the main container (the one with the white background and all the content like the images and paragraph), the border radius is (I think) too much if compared with the challenge, and the padding is less and doesn't look as good as the challenge design.
the image border radius has the same issue, it's too much.
The title's color does not match and the weight is too much. Maybe put 700 (as given in the style-guide.md file) and 400 for the paragraph (also given in style-guide.md)
There is also no visible box shadow in the container.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord