Submitted over 1 year ago
Solution of Product preview card component using Flexbox and Grid
@humbl3LilaS
Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted over 1 year ago
Hey there! 👋 Here is some feedback to further improve your code:
- The
section
element is being used incorrectly ⚠️ and not needed for this challenge.
- Only one
source
⚠️ is needed inside thepicture
element.
- The old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a
s
element and inside it you will add aspan
element with anvisually-hidden
class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
- NEVER ❌ do this as it creates accessibility issues for users and it is outdated, instead download a
px
torem
/em
converter in your code editor.
html { font-size: 62.5%; }
More Info:📚
Should I change the default HTML font-size to 62.5%?
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord