Francisco Carrillo• 5,540
@frank-itachi
Posted
Hello there 👋. You did a good job!
I have some suggestions about your code that might interest you.
HTML 📄:
- The heading order is important in the html structure so try to always start your headings and/or titles with an
<h1>
tag and then you can increase by one if you need to use more heading in your html code. So replace<h2>
by the<h1>
. - Get rid of the
class="container"
attribute of the<main>
tag because it should be used only once in the HTML file so it's not necessary to classify it. Learn more about this tag here.
CSS 🎨:
- Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy <coding />
😎!
Marked as helpful
0
utk145• 170
@utk145
Posted
@frank-itachi I see, I shall keep that order in mind. Thanks :)
0