Submitted about 3 years ago
solution huddle landing page with alt feature blocks with flex wrap
@rule-kells
Design comparison
SolutionDesign
Solution retrospective
Feedback is welcomed! Any tips on writing cleaner code would be much appreciated :)
Community feedback
- @pikapikamartPosted about 3 years ago
Hey, great work on this one. Layout in desktop is good and it scales well when going in mobile layout. The mobile layout is good as well.
Some suggestions would be:
- The
a
tag that wraps the website logo should havearia-label="homepage"
. This way, a user would know where this link would take them, hence, homepage. - The
try for free
could be better with usinga
tag on it. Since it doesn't really look like a control element on this one, it is much more of a link. - I would not wrap the hero-section in the
header
I personally add the hero-section for themain
element, because those acts like as the webpage's overview. get started for free
should be link as wella
.- I think the
hover
effect for the interactive element's are bit too much in terms of size.
FOOTER
- The
alt
for the icons of the website information such as the location, telephone, email should have usedalt=""
on them, because it doesn't really add content. - The six links should have been using
a
tags and be inside aul
element, since those are list of links. - The
a
tag that wraps the social media link should have aaria-label
which value corresponds to the social media name, likearia-label="facebook"
, this way users would know that this link would take them at facebook page.
Other than those, great job.
Marked as helpful0 - The
- @rule-kellsPosted about 3 years ago
Thanks for the detailed feedback. I greatly appreciate it. I will keep these in mind for future projects.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord