Solution from BrunoBiggle

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on your first challenge here in FEM.

  Suggestions for the layout.

  1. There seems to be a scrollbar at the bottom and we want to avoid it. We can fix this by adding overflow-x: hidden in the body tag. This way we could avoid overflowing in x-axis.

  2. Making the container class not be absolute. Since you declared the container to be this way, your body tag now does not have that much height. Because when we position: absolute an element, it goes out of flow, and any parent of that element, will change it's height or width to nothing since the element inside it is now out of flow. You should consider this one one.

  3. We avoided the scrollbar, but there is a large section at the bottom of the website, we can cut this one out via overflowing hidden it, but, as I mentioned above, your body tag does not have the dimension for it use overflow. It will work but in terms of structure, it does not do it right.

  The mobile state is fine, but the container sticks to the left side of the screen when reached 400px lower

  If you need help, feel free to drop it here ^

  1

  ---

  

  Bruno Cavalcante•50

  @brunobigglePosted over 3 years ago

  @pikamart I'll study that references to improve my code! Thank you very much!

  0