Skip to content
Submitted about 2 years ago

Solution for QR code component

Michał Sujkowski•70
@MichalSujkowski
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @MichalSujkowski 👋, good job on completing this challenge! 🎉

    Here are some suggestions you might consider:

    With semantic tags:

    <body>
   <main class="wrapper">
      . . .
   </main>
   <footer class="attribution">
      . . .
   </footer>
<body>
    • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
    • In this challenge, you should not use the background property to set the image because this image has semantic meaning. Use the CSS background property if the image is not part of the content.

    I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord