Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Solution for Product-preview-card-component-solution

Nithin 120

@Nithin-droid

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Account Deleted

Hello, I really liked your solution, but I wanted to share with you some things that can improve your work even more. I recently learned to use the picture tag, it is used to control different sizes of images, search for. And I would remove the originalPrice value from the css, and leave it in the html itself, as it would facilitate future maintenance.

0

Nithin 120

@Nithin-droid

Posted

@robertt-devv Thanks for the suggestion, I will try to make the changes. Didn't get the part "And I would remove the originalPrice value from the css", could you please elaborate.

0

Account Deleted

me refiro ao texto sublinhado, você originalmente quis usar <p>$149.99 <span>$169.99</span></p>, eu manteria assim, e não usaria

.price:after { content: "$169.99" }`

pois fica mais fácil mudar o valor no html, e os buscadores acharam esse valor com facilidade.

Marked as helpful

0
Nithin 120

@Nithin-droid

Posted

@robertt-devv Got it. Thank you.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord